[20822] Refactor Fast DDS Ubuntu CI to include several tests (backport #4860) #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
Cherry-pick of 22338f3 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
7 tasks
JesusPoderoso
force-pushed
the
mergify/bp/2.6.x/pr-4860
branch
from
cd766c7 to
2e359f4
Compare
* Refs #20822: Split current job into different jobs Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Add shapes demo build job Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Add discovery server build test job Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Add python build test job Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Add documentation build test job Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Remove previous documentation workflow Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Avoid building with tests if not running tests Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Try to fix documentation job Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Move conditions to reusable workflows Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Apply internal review suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Refactor meta files into build and test, and combine them in test steps Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Remove matrix from ubuntu CI Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Revert "Refs #20822: Move conditions to reusable workflows" This reverts commit d4eea0d. * Refs #20822: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Add missing discovery server requirements in the job Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Apply rev suggestions (2) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Fixing windows workflow by merging metas Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Add step with alternative builds Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Use colcon test meta in all jobs, and fix xfail filter Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Remove redundant CMake args, and fix alternative builds Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Apply rev suggestions (3) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Explicitly compare boolean inputs Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20822: Install tools on test steps to avoid losing symlink permissions Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #20822: Update discovery_server meta file name Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Adjust ternary operators Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20822: Use CCache based on an input parameter Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: eduponz <eduardoponz@eprosima.com> Co-authored-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 22338f3)
JesusPoderoso
force-pushed
the
mergify/bp/2.6.x/pr-4860
branch
from
2e359f4 to
fc3c06a
Compare
Mario-DL
requested changes
Jun 18, 2024
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Mario-DL
previously approved these changes
Jun 18, 2024
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
force-pushed
the
mergify/bp/2.6.x/pr-4860
branch
from
08ed3dd to
a79c555
Compare
JesusPoderoso
requested review from
JesusPoderoso
and removed request for
JesusPoderoso
JesusPoderoso
approved these changes
Jun 19, 2024
JesusPoderoso
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a "small" refactor in the Fast DDS Ubuntu CI.
It splits current CI into build and tests, and introduces new jobs that uses the already built library to build other products and run their test suite.
That would allow Fast DDS developers to detect possible issues that can affect other products while introducing changes in the Fast DDS library.
graph BT; fastdds_build_test --> fastdds_build fastdds_python_build --> fastdds_build fastdds_shapes_demo_build --> fastdds_build discovery_server_build_test --> fastdds_build fastdds_python_build_test --> fastdds_python_build fastdds_docs_build_test --> fastdds_python_build@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
N/A The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
N/A Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4860 done by [Mergify](https://mergify.com).